jarro2783 / cxxopts

Lightweight C++ command line option parser
MIT License
4.16k stars 582 forks source link

Avoid std::regex initialization during dlopen #406

Closed mxmlnkn closed 1 year ago

mxmlnkn commented 1 year ago

Suggested workaround for #405. Unfortunately, I have no minimal reproducer to test it against.


This change is Reviewable

jarro2783 commented 1 year ago

Are you able to get your user to try it with this fix to at least see if it fixes their actual problem.

mxmlnkn commented 1 year ago

I have already built a new release (indexed_bzip2 1.5.0) using this forked version of cxxopt and asked @ozancaglayan to try it out. I am yet to hear back.

jarro2783 commented 1 year ago

This seems like a good change anyway, but I would like to hear back if it solves the original problem.

mxmlnkn commented 1 year ago

Are you able to get your user to try it with this fix to at least see if it fixes their actual problem.

It (or some other change between indexed_bzip2 1.4.0 and 1.5.0) did fix the problem.