Fix overflow error in integer_parser (fixes #290)

jarro2783 / cxxopts

Lightweight C++ command line option parser

MIT License

4.16k stars 582 forks source link

Closed ololuki closed 7 months ago

ololuki commented 8 months ago

Checking for overflow should be done before integer overflows.

There are two checks:

(result > limit / base) is used for limits greater than rounded up to base, e.g. for 65535 it will activate for 65540 and higher.
(result * base > limit - digit) is used for limit+1 to limit+n below next base rounded number, e.g. 65536 up to 65539.

fixes #290

This change is

jarro2783 commented 7 months ago

Thanks for looking at this and fixing it for me.