Transaction support, placeholder slug for validation, and DX changes

jarrodconnolly / sequelize-slugify

Sequelize Slugify is a plugin for the Sequelize ORM that automatically creates and updates unique, URL safe slugs for your database models.

https://sequelize-slugify.nestedquotes.ca/

MIT License

56 stars 27 forks source link

Transaction support, placeholder slug for validation, and DX changes #10

Closed thebigredgeek closed 4 years ago

thebigredgeek commented 7 years ago

added transaction support, placeholder slug for validation, and updated tests for easier portability

thebigredgeek commented 7 years ago

https://github.com/jarrodconnolly/sequelize-slugify/issues/9

thebigredgeek commented 7 years ago

Not sure what to do about tests here. It looks like it might be difficult to test :(

thebigredgeek commented 7 years ago

@jarrodconnolly

davericher commented 6 years ago

bump

jarrodconnolly commented 4 years ago

Thank you for this contribution, it led me to better understand how Sequelize passes transactions to hooks. This has been implemented in an upcoming release of 1.x of this project.