Closed jarry-xiao closed 2 years ago
This PR would be better if we could refactor the remaining bit math to normal modular arithmetic.
Also, what does
Moved most direct assignment of variables into functions
mean?
Modular arithmetic will not save you when you do a wrapping sub for your index (unless we want to change those to i64
s)
traverse_to_parent
to abstract away the ugly (and highly duplicated) code that hashes a reference node up the treeChangeLog
class that handles proof node or leaf replacement. If this existed months ago, we would have never introduced the bug in replacing the RMLempty_node_cached
when possible (O(N^2) -> O(N)) preprocessingappend
to be more easily readableAll test cases pass and smoke test is chugging along