jarry-xiao / candyland

Proof of concept program for compressing NFTs
GNU Affero General Public License v3.0
111 stars 13 forks source link

Cleaned up CMT lib by refactoring away a couple common functions #137

Closed jarry-xiao closed 2 years ago

jarry-xiao commented 2 years ago

All test cases pass and smoke test is chugging along

jarry-xiao commented 2 years ago

This PR would be better if we could refactor the remaining bit math to normal modular arithmetic.

Also, what does Moved most direct assignment of variables into functions mean?

Modular arithmetic will not save you when you do a wrapping sub for your index (unless we want to change those to i64s)