jart / fabulous

Print images, colors, and stylish text to the terminal with Python
Apache License 2.0
347 stars 34 forks source link

Python 3 Support? #11

Closed TheDataLeek closed 8 years ago

TheDataLeek commented 8 years ago

When installing with pip3 this fails because of the py2-style print commands. All of the documentation also uses py2 syntax.

What is the roadmap for python 3 support?

jart commented 8 years ago

You're the first person to request it. If you want it, I'll do it.

TheDataLeek commented 8 years ago

Yeah, that would be awesome! I mostly just use Python 3, and it would be cool to start incorporating this into some of my tools. Colours always make things better and using the raw ANSI codes is a huge pain.

Cheers!

willtheorangeguy commented 8 years ago

It would love it too if you could do Python 3 because I mostly use it too.

jart commented 8 years ago

Ok working on it.

willtheorangeguy commented 8 years ago

I'd be fine with helping if you need it.

jart commented 8 years ago

I'm going to need though code review. I'll send out a pull request to all of you today or tomorrow. Once it's submitted I'll cut a new release. On Jul 7, 2016 5:36 PM, "William" notifications@github.com wrote:

I'd be fine with helping if you need it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jart/fabulous/issues/11#issuecomment-231214850, or mute the thread https://github.com/notifications/unsubscribe/AADAbrLlJ5fIG5LrLVR-KcgaXu3OWyAqks5qTXF2gaJpZM4JHZth .

jart commented 8 years ago

Correction: thorough On Jul 7, 2016 5:56 PM, "Justine Alexandra Roberts Tunney" < jtunney@gmail.com> wrote:

I'm going to need though code review. I'll send out a pull request to all of you today or tomorrow. Once it's submitted I'll cut a new release. On Jul 7, 2016 5:36 PM, "William" notifications@github.com wrote:

I'd be fine with helping if you need it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jart/fabulous/issues/11#issuecomment-231214850, or mute the thread https://github.com/notifications/unsubscribe/AADAbrLlJ5fIG5LrLVR-KcgaXu3OWyAqks5qTXF2gaJpZM4JHZth .

willtheorangeguy commented 8 years ago

OK

TheDataLeek commented 8 years ago

Sounds good! I don't have a ton of time to contribute to the project, but I'd be more than happy to help review.

Thanks!

jart commented 8 years ago

Is it considered acceptable to not support 3.0, 3.1, and 3.2? As in, 3 support would only be 3.3 and greater.

jart commented 8 years ago

Yeah Python 2∩3 is not a fun language. Almost done.

jart commented 8 years ago

For posterity: https://github.com/jart/fabulous/pull/12

jart commented 8 years ago

@arielb2 @willzfarmer @willtheorangeguy I just cut a Python 3.{3,4,5} compatible release. Enjoy!

willtheorangeguy commented 8 years ago

Thanks for working on that!!