jaruba / PowderPlayer

Hybrid between a Torrent Client and a Player (torrent streaming) -
https://powder.media/
GNU Lesser General Public License v2.1
585 stars 95 forks source link

[Setting] Set Priority for Subtitle Types #89

Open samukets opened 8 years ago

samukets commented 8 years ago

Problem to learn subtitle choice for other videos from playlist, please, try to select português (.srt) subtitle and play next video, powder dont fix choice.

UPLOADING VIDEOS

samukets commented 8 years ago

LINK to download Vídeos: https://drive.google.com/file/d/0B-zID4I33vBSSWpzTlZMVlV6b0E/view?usp=sharing

Link to SRT files https://drive.google.com/file/d/0B-zID4I33vBSeURYMUJUQm1zT0U/view?usp=sharing

jaruba commented 8 years ago

Could you explain the issue in more detail? Wore the files in the playlist local or from torrents?

The "remember subtitle choice" feature applies to internal video subtitles only (such as those in mkv files), and only reselects those if it can find an internal subtitle with the exact same name in the next playlist item too.

samukets commented 8 years ago

I test here too many times and the problem is internal has preference, .srt had to been preference Always, Always load .srt fist if that is on same folder with same name...

So the option if only one or always on internal only will be used if subtitle .srt are not available (sorry for that)

Next we have that problem:

Kill.la.Kill.S01E02.So.Sexy,.Im.Going.to.Faint.mkv and file Kill.la.Kill.S01E02.So.Sexy,.Im.Going.to.Faint.srt are on the same folder and no subtitles are founded

Links is on upside

samukets commented 8 years ago

Option NONE on subtitle was not remembered when we go to next video in playlist mode, so if none was selected on first video, this have to be remembered on next videos.

i guess https://github.com/jaruba/PowderPlayer/issues/84 have to be reopened and we have to do more tests with different scenarios, videos, playlist, choose preference order or preference order need to be selectable...

jaruba commented 8 years ago

uhm... I can't consider none to be a choice that needs to be remembered.. because if your playing a file, that file doesn't have any internal subs so you can't select your language, but might have if it was available. I think only valid selections should be remembered..

samukets commented 8 years ago

The problem is, when we enable use internal sub or we have srt sub on folder and we want to play ep1 to ep10 with no subtitle, autoload and internal option dont remember what we choose no subtitle to reproduction and we need to disable subtitle from every ep...

jaruba commented 8 years ago

Then maybe a checkbox in the subtitle menu for "Disable Auto-Load" would be more fitting.

samukets commented 8 years ago

1- Invert priority, .srt come before internal 2- For me select none and remember for playlist is more simple than uncheck auto-load button but if you prefer you can walk in this button patch... 3- We need to do scan option to folder, local videos load srt...