jaruba / PowderWeb

Modern Bittorrent Client with Web UI and Torrent Streaming Capabilities. Also Supports Acestream / SopCast Live Streams, Youtube-dl Links and Local Files.
https://powder.media/
91 stars 24 forks source link

Acestream download not working #56

Open Tekka90 opened 4 years ago

Tekka90 commented 4 years ago

Using headless version (didn't try with others) Inside a container (if that may be the issue) when I try to use a acestream link in powderweb, it detects that ace stream is not installed (ok) downloads it and then immediately get an error in log stating the zip is not valid.

Looking into details, I find that the acestream.zip file it downloaded in /tmp is empty.

launching by hand "wget https://powder.media/ace/linux/acestream.zip" get me the same result. Maybe the file did move ?

jaruba commented 4 years ago

That's because automated installation of the AceStream server is not available for Linux. It's still a bug because it should not try to download a Linux version at all.

Check the wiki regarding installing the AceStream server on Linux: https://github.com/jaruba/PowderWeb/wiki/Enable-Acestream

jaruba commented 4 years ago

I see the issue now, it's because it checks the OS of the browser instead of the OS of the server when it shows you the "not installed" message.

Tekka90 commented 4 years ago

Arggg sorry one more time it was in the wiki/documentation :( Snap is not the best option for docker, but I will take care of including it in the image. I already added sopcst which requires a bit of changes in the initial image... I'll share once am done. Should I do a pull request for the Dockerfile ? Or you prefer to keep it in another location ?

jaruba commented 4 years ago

AceStream could (theoretically) run in a separate docker container:

It shouldn't be a problem that the AceStream docker build is old, AceStream didn't really update their software for that long either, but the protocol should still work as expected.

SopCast probably could too:

I'm wondering if the official Dockerfile should include them or not. Or maybe we could publish 2 docker images? One that doesn't include them and one that does? My thinking is that many users might not use (or even want) these features at all.

jaruba commented 4 years ago

I'm having second thoughts about this, as long as ace / sop are installed but not used unless Powder Web starts them itself (which it's meant to do only when someone tries to play a ace / sop link) then I see no issues with including them in the official Dockerfile.

So if you get them working, I'd happily accept a PR. But keep in mind that Powder Web looks for ace at /snap/acestreamplayer, check this line: https://github.com/jaruba/PowderWeb/blob/b45d64abddbb33f65120ae292e6cc9b8576d56d6/server/acestream.js#L610

So if u use something else to install it, we will probably need to add a new possible ace path to the code.

jaruba commented 4 years ago

@Tekka90 any update on this? did you get stuck with installing acestreamplayer?