search

jaruba / ha-samsungtv-tizen

📺 HomeAssistant - For Samsung TVs 2016+, Includes SmartThings API and Channel List Support
Apache License 2.0
285 stars 64 forks source link

Confusing setup instructions? #136

Open igorsantos07 opened 3 years ago

igorsantos07 commented 3 years ago

I tried configuring the package by adding the Mac address and IP, as instructed in the README... But it didn't work. The original integration works fine, though.

Then, on a second view, I stumbled upon SmartThings.md, followed it and got the TV working.

Thus:

  1. I would suggest making it clearer about the SmartThings setup, since it seems necessary at least for some devices.
  2. I see there's a fork by Ollo69 that improves configuration and has clearer instructions. I wonder if you have seen it already and if there are plans for merging it in.
  3. do you have any idea how to bring these improvements to the upstream, main HA integration? I've seem a couple of HACS packages that are great but stay in that "second level".

Bonus: I also had to google how to find the MAC Address for my TV, since it's not needed by the main integration. Some help about that would also be handy, if it's still needed after the merge.

jaruba commented 3 years ago

@igorsantos07 there is already a branch in which we merged ollo's changes, the only thing that is missing are the docs for it. ollo himself also has complete access to this repo too.

i am supposed to write the docs, but 2 weeks ago both my Samsung TVs went offline from SmartThings for some reason (i'm suspecting Pi Hole / AdGuard as the reasons behind it). Due to efforts for work and the many many other side-projects I maintain, I was yet to get the TVs functional again within SmartThings to work on the docs.

You seem to have a clear vision of how the docs should be handled, if you wish to help in this regard we will gladly accept more contributors.

igorsantos07 commented 3 years ago

Neat! It was hard to track progress of changes from the forum.

I'll wait for the final merges to chime in about the docs, and PR improvements if "needed". Otherwise, [his config section] (https://github.com/ollo69/ha-samsungtv-smart#configuration) seems clear enough on steps and need of SmartThings token.

And please, just don't apologize for having a life! 😁 Although I understand how sometimes we feel that need around Github 😅