search

jaruesink / coop

prototyping
1 stars 0 forks source link

Cleaned up fbOauth code #18

Closed clayrisser closed 8 years ago

clayrisser commented 8 years ago

Reformatted and cleaned up fbOauth code, and fixed issue #17

clayrisser commented 8 years ago

I got rid of the Promises and fat arrow functions. I can put the fat arrow functions back if you want me too. The code is a lot more succinct and readable.

jaruesink commented 8 years ago

haha Jam, this was a nice try. But it still leaves the original problem of not the next view not able to render the ngModel. This happens when you run a router.navigate inside of an asynchronous call. This is why we had to use the promises. I'll clean up my code and show you what I had in mind as far as readable.