search

jarun / advcpmv

A patch for GNU Core Utilities cp, mv to add progress bars
765 stars 72 forks source link

Revert "Add 9.0 patch" #8

Closed jarun closed 3 years ago

jarun commented 3 years ago

Reverts jarun/advcpmv#7

Copy-paste happens but I don't see a single progress bar. Please fix that and re-raise the PR.

ghost commented 3 years ago

@jarun @Zackptg5 It looks like the cause of this issue is the Copy-on-Write feature that was added in coreutils 9.0. The progress bar appears normally for me when I disable this feature at runtime using --reflink=never.

Zackptg5 commented 3 years ago

I cross-compile coreutils for android and don't have this problem there so didn't notice but I can reproduce when compiling for regular linux. @jarun Can confirm what @whalehub says for linux compiles: --reflink=never flag is needed for cp only and is unique to it for reasons in his post, not needed for mv

Patch is fine in it's current state but may want to disable reflink at compile time if possible or find another workaround though

jarun commented 3 years ago

Could you update the patch to disable reflink for cp as well?

Zackptg5 commented 3 years ago

Could you update the patch to disable reflink for cp as well?

Done, see https://github.com/jarun/advcpmv/pull/9 (here for the reflink disable line)