[bukuserver] New tab bug fix

[LeXofLeviafan]

fixes #658:

• adding manual popup window check to close_if_popup() macro (instead of relying on browser check)

[rachmadaniHaryono]

i also added issue to https://github.com/jarun/buku/wiki/PR-guidelines#testing-bukuserver

[LeXofLeviafan]

https://github.com/jarun/buku/wiki/PR-guidelines#testing-bukuserver

The purpose of this section isn't clear to me. Is it meant for manual testing? It should be clarified in this case. (…And the list is kinda lengthy – it would make sense to go over those cases when preparing for a release, but not on a regular basis. There should be a way to automate at least some of those, too… Not the new tab thing tho, it's specific to builtin browser functionality.)

…Might want to mention navigation (cancel, save, save-and-add-another, save-and-continue-editing) for popup windows as well.

[rachmadaniHaryono]

Is it meant for manual testing? It should be clarified in this case. (…And the list is kinda lengthy – it would make sense to go over those cases when preparing for a release, but not on a regular basis. There should be a way to automate at least some of those, too… Not the new tab thing tho, it's specific to builtin browser functionality.)

yes it is manual testing for now. i think it is just as suggestion of what should be done before release.

new pr/feature may only test part of it.

for automation case, i don't know enough how to automate it. use selenium? also maybe check all links on bukuserver page for 404

new tab case is removed from that list

…Might want to mention navigation (cancel, save, save-and-add-another, save-and-continue-editing) for popup windows as well.

added on bookmarklet and bookmark creation test case

[jarun]

Thanks guys!

[LeXofLeviafan]

for automation case, i don't know enough how to automate it. use selenium? also maybe check all links on bukuserver page for 404

…I've looked up how Flask apps are meant to be tested, and ended up implementing a few functional tests. They don't cover the entire thing, of course (since they test server responses, not the client behaviour – e2e is more of a hassle to set up, and it's rather unstable), but they should at least halve the required manual testing. And I reckon there's a potential for more tests to be made (I mostly covered the bookmarklet popup, bookmark editing and configurable functionality), but I'm content with what I have at the moment :sweat_smile: