Feature/bukuserver test cache

[rachmadaniHaryono]

• pytest-vcr is not active anymore, last commit july 20, 2020
• vcrpy recomment pytest-recording https://vcrpy.readthedocs.io/en/latest/#usage-with-pytest
• edit precommit config for darker to not change single quote character

related https://github.com/jarun/buku/issues/442

@jarun you hesitate to add new files to repo but this yaml recordings are important for test consistency.

@LeXofLeviafan mention that he also have diffculty on getting the same result https://github.com/jarun/buku/pull/632

it doesnt mean direct network test is not possible or not needed but it is not the default

i think this test also failing several times, so maybe it is time to cache it

last thing, i added @LeXofLeviafan as reviewer. if you still have error on test i will change it

[LeXofLeviafan]

…The google search test is passing on my machine in this branch, for all Python versions.

Though there's two tests (test_buku.py::test_edit_rec & test_buku.py::test_sigint_handler) which get marked as "skipped" (the comment for the first one says "can't patch subprocess"), one more is apparently "deselected", and there's a bunch of deprecation warnings. Is this intended? If not, it should probably be rectified.

I think this test also failing several times

The current master didn't pass testing due to this test failing once (due to Google server DDoS detection)… and the same exact thing happened to my latest pull request :joy:

[rachmadaniHaryono]

Is this intended? If not, it should probably be rectified

probably not, but the target for now just to make upstream test working again

The current master didn't pass testing due to this test failing once (due to Google server DDoS detection)… and the same exact thing happened to my latest pull request joy

i think this happen several time and the test have to to be manually restarted. so this should be never happen again

[LeXofLeviafan]

and the test have to to be manually restarted

Oh, right; there was such a feature on Github.

…I don't think I have access for that tho :sweat_smile:

[jarun]

Thank you!

[LeXofLeviafan]

…An important note: this change isn't applied by tox correctly in a pre-existing repo clone until you delete the .tox/ subfolder (it tries to create new cassette files without substituting / characters in their names, for some reason).

[jarun]

I don't understand. We don't have any .tox directory in buku repo.

[LeXofLeviafan]

Of course we don't – it's listed in .gitignore :smile:

It's the local files created by tox on the first run (I think).

[jarun]

I have added a cooking section in the ToDo list now: https://github.com/jarun/buku/issues/484 We will use that to generate a release changelog.

Can you please add this note there?

[LeXofLeviafan]

You mean editing your comment? Or posting a new comment in the issue discussion?

[jarun]

Please share what should the note be here.

[LeXofLeviafan]

"If you have a local repo clone, remove .tox/ subfolder if it's there before you run tests for the first time"