search

jarun / buku

:bookmark: Personal mini-web in text
GNU General Public License v3.0
6.45k stars 294 forks source link

TODO: support the incoming v2.0 release of flask-admin #753

Open LeXofLeviafan opened 1 month ago

LeXofLeviafan commented 1 month ago

i18n

Currently (as of v1.6.1), flask-admin i18n depends on flask-babelex if it's present, falling back to flask-babel otherwise. Meaning, flask-babel is only used when flask-babelex is not installed. For that reason, we're doing the same thing exactly.

However, recently flask-babel repo got a breaking change merged in, removing all dependencies on flask-babelex. They're planning to make a release candidate for the next version soon (appropriately numbered v2.0, since it includes breaking changes).

We should include appropriate changes in the next (patch?) release, migrating to the new flask-admin version once it's available, and removing dependency on flask-babelex accordingly.

bootstrap

The incoming release of flask-admin is going to drop the support for Bootsrap2 & Bootstrap3 themes. We're currently using the Bootstrap3 theme, so migrating bukuserver to Bootstrap4 would be necessary.

(Note: Bootstrap4 is supported by the version of flask-admin we're currently using, so we don't need to wait for the next release of flask-admin to implement this chance)

jarun commented 1 month ago

We should include appropriate changes in the next (patch?) release, migrating to the new flask-admin version once it's available, and removing dependency on flask-babelex accordingly.

If we have enough users requiring a patch, we'll release one. Else it would be a regular release. If there are certain steps that need to be run before the release, please share. Otherwise, you can also make the next release. That would be simpler. Please let me know if you need any permissions.

LeXofLeviafan commented 1 month ago

We still haven't released a version with the fix for #729 (even though the fix was merged in April)

jarun commented 1 month ago

Right, I am still waiting since only one user reported it... so it may not be a widespread issue right now.

LeXofLeviafan commented 1 month ago

Rather than not being widespread, that user noticed it immediately due to running his own tests in a package manager repo, essentially :sweat_smile:

(And I guess most Buku users who visit GitHub are already used to running nightly, seeing as they couldn't install the latest version from PyPI for months if not years by that point :thinking:)

jarun commented 1 month ago

Can you make a release? Please let me know if you need anything.

Release checklist: https://github.com/jarun/buku/wiki/Release-checklist

LeXofLeviafan commented 1 month ago

I'd rather wait for the release of the new flask-admin version (and add support for it); it appears that in addition to i18n changes, they're also removing bootstrap3 theme support, making further changes necessary to support the new flask-admin release.