jarun / buku

:bookmark: Personal mini-web in text
GNU General Public License v3.0
6.47k stars 295 forks source link

[jarun#753] pre-migration WebUI fixes #761

Closed LeXofLeviafan closed 1 month ago

LeXofLeviafan commented 1 month ago

As I mentioned, I've been working on Bootstrap v4 migration; while doing so, I made a number of fixes and adjustments that aren't strictly related to Bootstrap v4, so I made a separate pull-request for them to be merged before migrating to the newer Bootstrap version.

This includes the following changes:

jarun commented 1 month ago

Thank you!

Please let me know if you have any more immediate fixes/improvements in mind. Otherwise, I'll plan for a release.

LeXofLeviafan commented 1 month ago

I actually have the Bootstrap v4 changes more or less ready (sans screenshots), but if we merge those in we'll need to wait for the flask-admin release (since there's at least one bug that was fixed in upstream after the current release).

I'm actually not sure why they're stalling the release (they've been quiet for 2 weeks now), but I'm pretty sure it's going to happen sooner rather than later… and we'll probably need to make a release after that regardless of whether we release Bootstrap v3 changes now. (If you don't see a problem with that, then making a release before migration seems like a good idea.)

Other than that, I only had a thought about adjusting the title/name filter (in Bookmarks/Tags pages, respectively) so that it actually allows for partial match – the filter is nearly useless without it (for manual usecase).

P.S. Have you seen my question about migrating dev team posts? I don't seem to have the access to do it (which makes sense but then why do I have the button? :sweat_smile:)

jarun commented 1 month ago

but if we merge those in we'll need to wait for the flask-admin release (since there's at least one bug that was fixed in upstream after the current release)

We can wait for a while. No issues. How frequently do they release?

I tried to migrate the team posts, but it didn't work out. It is not listing the new Buku project discussion thread. It has an option to enable discussions under Buku-dev and then probably we can migrate to that. However, I think it's convenient to use the project's discussion thread.

LeXofLeviafan commented 1 month ago

How frequently do they release?

I don't think they have a schedule, but the only remaining item they have on their pre-release TODO list is "Remove any existing DeprecationWarnings" :sweat_smile:

As for team posts migration, I believe it's supposed to be migrated to either organization or a repo within it. And yes, we can use that but the point for migrating them is to at the very least have access to the posts archive in GitHub UI (as opposed to trying to navigate a single JSON file)… and I guess that would allow to discuss development plans before going public with them, as the team posts allowed (since I don't believe there's a way to make a public repo discussion non-public).

jarun commented 1 month ago

OK. Please ping me once they are through their release.