jarun / buku

:bookmark: Personal mini-web in text
GNU General Public License v3.0
6.52k stars 294 forks source link

buku 4.9 is incompatible with urllib3 >2 #776

Open Remiol opened 2 months ago

Remiol commented 2 months ago

Thank you for the new 4.9 version although I am sorry to see that none of the new features I requested have been added.

I updated it in pypi but get an error message:

buku 4.9 requires urllib3<2,>=1.23, but you have urllib3 2.1.0 which is incompatible.

LeXofLeviafan commented 2 months ago

A suggestion off the top of my head: install Python apps in a sandbox, not in your system-/user-global packages. That would probably help with a lot of potential compatibility issues :sweat_smile:

That being said, I can't recall for sure but I think urllib3 was blocked by a dependency lib, which may or may not be updated before our next release :thinking: (…I'll check it again later, just in case)

although I am sorry to see that none of the new features I requested have been added.

If you mean #702, it had been implemented back in March and was included in the v4.9 release: commit

LeXofLeviafan commented 2 months ago

I think urllib3 was blocked by a dependency lib, which may or may not be updated before our next release

…Turns out that is indeed the case.
This should be fixed in #753 (which is supposed to be included in the upcoming release).

Remiol commented 2 months ago

A suggestion off the top of my head: install Python apps in a sandbox, not in your system-/user-global packages. That would probably help with a lot of potential compatibility issues 😅

That being said, I can't recall for sure but I think urllib3 was blocked by a dependency lib, which may or may not be updated before our next release 🤔 (…I'll check it again later, just in case)

although I am sorry to see that none of the new features I requested have been added.

If you mean #702, it had been implemented back in March and [was included in the v4.9 release](https://github.com/jarun/

Oh wow. Tnx. I didn't notice it right away.

Remiol commented 2 months ago

Python 3.13 is coming. Is it also possible to make Buku compatible with Python 3.13?

LeXofLeviafan commented 2 months ago

It's a bit of a long shot considering the upcoming Python release will not be out until after 3 weeks… Though it's probably not going to take much effort other than adding the new version to project settings, CI and tox config.

…Either way, I suggest you create a separate issue to track Python 3.13 support; I don't believe it's in scope of this one.

Remiol commented 3 weeks ago

Buku is still incompatible with the latest version of urllib3.

I can't update urllib3.

LeXofLeviafan commented 3 weeks ago

Buku is still incompatible with the latest version of urllib3.

As I mentioned before, this issue cannot be resolved before #753 (since the newer versions of urllib3 are blocked by the other dependencies).

If you need it globally, you should install buku in a dedicated sandbox instead (which I mentioned before as well).

Remiol commented 3 weeks ago

I have read that by putting buku in a sandbox you can make it work but I thought it was temporary and you guys were working on making it compatible with the latest urllib, which is why I waited. I still haven't updated urllib3.

I have to uninstall buku first isn't it and than install it with pipx? I don't lose the url's?

Update: resolved my question.

LeXofLeviafan commented 3 weeks ago

I thought it was temporary

…It is, but the ball is not in our court right now :sweat_smile:

I have to uninstall buku first isn't it and than install it with pipx?

pipx installs Python package(s) inside the personal directory of a user (~/.local/pipx/venvs in case of Linux); it's completely separate from system packages, so you probably don't need to uninstall the system-wide buku before trying out a sandboxed install (though having more than one installation might get confusing unless you're sure which one you're currently trying to use).

I don't lose the url's?

The bookmarks database is stored in the user settings (~/.local/share/buku/bookmarks.db by default, in case of Linux). User files are not affected by the system installation, but you can back up the file (or the directory it's in) manually whenever you feel like doing so.

Remiol commented 3 weeks ago

Thank you

The database is stored in "c:\Users**\AppData\Roaming\buku" in Windows.