jarun / buku

:bookmark: Personal mini-web in text
GNU General Public License v3.0
6.53k stars 294 forks source link

fixing filters being reordered after editing #778

Closed LeXofLeviafan closed 2 months ago

LeXofLeviafan commented 2 months ago

fixes #624 (as a workaround):

also:

Note: this also deals with the upstream bug mentioned in #777 (externally); though these two pull-requests might have a minor merge conflict with each other due to how git calculates changes (i.e. their modifications affect adjacent lines)

Example

![before](https://github.com/user-attachments/assets/f39a0182-1394-4548-816a-313b9e905e71 "before") (changed a filter in the middle – this would normally cause it to be numbered last) ![modifying filters](https://github.com/user-attachments/assets/a6cc17a7-f7a1-4af1-9b1b-c7edc6e76bea "modifying filters") (after submission) ![after](https://github.com/user-attachments/assets/4b25ee93-d7a0-4a9a-b15b-98bdde5d93f8 "after") URL query (formatted for readability): ``` ?flt0_title_equals=a &flt1_title_equals=b &flt2_title_equals=c &flt3_title_not_equal=D &flt4_title_equals=e &flt5_title_not_equal=F &flt6_title_equals=g &flt7_title_equals=h &flt8_title_equals=i &flt9_title_not_equal=J &fltA_title_equals=k &fltB_title_not_equal=L &fltC_title_equals=m &fltD_title_equals=n ```
jarun commented 2 months ago

There's a merge conflict. Please resolve and merge.

LeXofLeviafan commented 2 months ago

@jarun fixed the conflict & updated completion files

jarun commented 2 months ago

Thank you!