search

jarun / ddgr

:duck: DuckDuckGo from the terminal
GNU General Public License v3.0
2.92k stars 139 forks source link

Next page search needs vqd? #117

Closed RTek-dev closed 4 years ago

RTek-dev commented 4 years ago

Posting with the vqd parameter taken from the button seems to allow next/prev to function again. nextParam is now returned blank (a change on DuckDuckGo search page?). I don't have any previous data for the duckduckgo parameters to compare as I've only just started using ddgr.

nextParam logic may now be partial redundant as always seems to be blank.

jarun commented 4 years ago

Hi,

Is this PR still valid?

RTek-dev commented 4 years ago

Hi jarun, This is my first contribution to a project so I'm still learning the whole Git process (sorry!).

The code does work on my machine but the circleci build failed so I put the request into draft mode. Never used circleci before so need to learn that too.

Do you want me to reopen the pull request so you can test it?

(noob in training!)

jarun commented 4 years ago

Works fine for me! I am reopening this PR. Let's see where Ci fails.

jarun commented 4 years ago

Lint check is complaining that an inline comment should start with # and not # (the space after # is required).

I will fix those.

jarun commented 4 years ago

Thank you so much for taking your time to fix this!

RTek-dev commented 4 years ago

No problem, was a good learning experience!