search

jarun / googler

:mag: Google from the terminal
GNU General Public License v3.0
6.11k stars 529 forks source link

Do not print an additional blank line when abstract is empty #357

Closed zmwangx closed 4 years ago

zmwangx commented 4 years ago

Not actually sure why we never changed this... But I happened to be developing against a request that resulted in an empty abstract today, and the double blank line sure looked pointless (especially when it's repeated due to the result duplication bug).

Before (yeah, this is without the duplicate suppression):

$ ./googler python3.5 eol

 1.  Is there official guide for Python 3.x release lifecycle? - Stack ...
     https://stackoverflow.com/questions/40655195/is-there-official-guide-for-python-3-x-release-lifecycle

 2.  Is there official guide for Python 3.x release lifecycle? - Stack ...
     https://stackoverflow.com/questions/40655195/is-there-official-guide-for-python-3-x-release-lifecycle

 3.  17. Development Cycle — Python Developer's Guide
     https://devguide.python.org/devcycle/
     A branch less than 5 years old but no longer in maintenance mode is a ... For reference, here are the Python versions that most recently reached their
     end-of-life: ...

After:

$ ./googler python3.5 eol

 1.  Is there official guide for Python 3.x release lifecycle? - Stack ...
     https://stackoverflow.com/questions/40655195/is-there-official-guide-for-python-3-x-release-lifecycle

 2.  Is there official guide for Python 3.x release lifecycle? - Stack ...
     https://stackoverflow.com/questions/40655195/is-there-official-guide-for-python-3-x-release-lifecycle

 3.  17. Development Cycle — Python Developer's Guide
     https://devguide.python.org/devcycle/
     A branch less than 5 years old but no longer in maintenance mode is a ... For reference, here are the Python versions that most recently reached their
     end-of-life: ...

(As an aside, it would be nice if we could actually display the text in a featured snippet, but those snippets are a little bit too liberal in format to reliably parse, so I guess we're stuck with a bare title and URL for now).

zmwangx commented 4 years ago

Btw we've racked up a sizable list of fixes and improvements so it might be time to consider a release.

jarun commented 4 years ago

Thank you!

That's true. I'll make a release soon.

jarun commented 4 years ago

I will make the release sometime next week.

jarun commented 4 years ago

packaging for arch linux is still failing. See https://github.com/BytePackager/packagecore/issues/204

zmwangx commented 4 years ago

This has caused way too much trouble than its worth, my impression is it's been failing half of the time when we used it. I'm also like 99.9% sure no arch user install the package this way -- there's just no reason to not use AUR which should always be on the latest version. Why don't we just remove it.

jarun commented 4 years ago

Agreed. Will do this next week.