jarun / googler

:mag: Google from the terminal
GNU General Public License v3.0
6.11k stars 529 forks source link

New Design for Google News #415

Closed y-shimada0402 closed 3 years ago

y-shimada0402 commented 3 years ago

-N option is not working. The /tmp/googler-response*.html output by --debug is retrieved. Thanks for your help.

Bug reports

googler --upgrade Downloading https://raw.githubusercontent.com/jarun/googler/v4.3.2/googler Already up to date.

googler -N --debug COVID-19 [DEBUG] googler version 4.3.2 [DEBUG] Python version 3.8.10 [DEBUG] Platform: Linux-5.4.0-84-lowlatency-x86_64-with-glibc2.29 [DEBUG] Connecting to new host www.google.com [DEBUG] Opened socket to 172.217.175.4:443 [DEBUG] new_connection completed in 0.081s [DEBUG] Fetching URL /search?ie=UTF-8&oe=UTF-8&q=COVID-19&sei=cAjwph9ESeSOyzYBwXmcqw&tbm=nws [DEBUG] Cookie: 1P_JAR=2021-09-15-04 [DEBUG] fetch_page completed in 1.298s [DEBUG] Response body written to '/tmp/googler-response-kjib3xmq.html'. [DEBUG] parse completed in 0.169s No results. [DEBUG] Fetching https://raw.githubusercontent.com/jarun/googler/master/info.json for project status... If you believe this is a bug, please review https://git.io/googler-no-results before submitting a bug report.

Before opening an issue, please

💥💥TRY TO REPRODUCE ON THE LATEST DEVELOPMENT VERSION FIRST💥💥

The bug you noticed might have already been fixed.

If the issue can be reproduced on master, then please make sure you provide the following:

If we need more information and there is no communication from the bug reporter within 7 days from the date of request, we will close the issue. If you have relevant information, resume discussion any time.

Feature requests

Please consider contributing the feature back to googler yourself. Feel free to discuss. We are more than happy to help.

--- PLEASE DELETE THIS LINE AND EVERYTHING ABOVE ---

rfaile313 commented 3 years ago

Can also confirm this is broken.

# googler --version
4.3.2

# googler business

 1.  Business - Wikipedia
     https://en.wikipedia.org/wiki/Business
     Business is the activity of making one's living or making money by producing or buying and selling products
     Simply put, it is "any activity or enterprise ...

 2.  Business - Insider
     https://www.businessinsider.com/
     Business Insider tells the global tech, finance, markets, media, healthcare, and strategy stories you want to
     know.

 3.  business.com: Expert Business Advice, Tips, and Resources
     https://www.business.com/
     Get the business advice, tips, and resources you need to run and grow your business.

 4.  Google My Business - Manage Your Business Profile
     https://www.google.com/business/
     Get your business listed on Google with a free Business Profile. See how you can turn people who find you on
     Search and Maps into new customers.

 5.  Business Definition - Investopedia
     https://www.investopedia.com/terms/b/business.asp
     A business is defined as an organization or enterprising entity engaged in commercial, industrial, or
     professional activities. Businesses can be for-profit ...

 6.  21 Great Small Business Ideas to Start in 2021
     https://www.businessnewsdaily.com/2747-great-business-ideas.html
     What are the most successful small businesses?
     Choose a business idea that you are knowledgeable and passionate about. Before starting a business, determine if
     there is a demand for what you want to provide.

 7.  Businessweek - Bloomberg
     https://www.bloomberg.com/businessweek
     Black-Owned Businesses Hope the Summer Boom Doesn't Fade · relates to Black Lives Matter Creates a Boom for
     Black-Owned Bookstores. Small Business ...

 8.  Small Business Administration
     https://www.sba.gov/
     We support America's small businesses. The SBA connects entrepreneurs with lenders and funding to help them plan,
     start and grow their business.

 9.  Business | City of San Jose
     https://www.sanjoseca.gov/business
     Updates on City of San José Services and/or Operations (English | Español | Tiếng Việt | 中文). COVID-19 Pandemic
     Help for Residents | Businesses | Nonprofits.

googler (? for help)

# googler business --news
No results.
If you believe this is a bug, please review https://git.io/googler-no-results before submitting a bug report.
googler (? for help)

[DEBUG] googler version 4.3.2 [DEBUG] Python version 3.6.9 [DEBUG] Platform: Linux-4.15.0-144-generic-x86_64-with-Ubuntu-18.04-bionic

Debug HTML output

jarun commented 3 years ago

If you care enough to contribute, please raise the PR.

rfaile313 commented 3 years ago

@jarun howdy 👋 I poked around the binary a bit the other day before I posted, It was not super clear to me how to adjust for the changed news cards, it did not seem as trivial as adjusting a selector which is why I posted here.

If you would not mind pointing me in the right direction I would be happy to test some local changes and cut a PR.

jarun commented 3 years ago

Please enable the debug flag and check the html response dumped. Open the same search in another device. Do you see the results in the dump? If yes, the parser needs to be modified to show the results. If not, the cards are javascript which needs many other changes.

rfaile313 commented 3 years ago

@jarun ok thanks - submitted a PR with a fix👍

jarun commented 3 years ago

Thank you!

y-shimada0402 commented 3 years ago

@rfaile313 san I am grateful for your support. Arigatou gozaimasu. I’m studying English really hard, but I’m not very good at it. I'm learning github.

@jarun howdy wave I poked around the binary a bit the other day before I posted, It was not super clear to me how to adjust for the changed news cards, it did not seem as trivial as adjusting a selector which is why I posted here.

If you would not mind pointing me in the right direction I would be happy to test some local changes and cut a PR.

jarun commented 3 years ago

I am reopening the issue as the fix is not accurate and the dev hasn't tried to fine-tune despite follow-ups.

jarun commented 3 years ago

Fixed at commit 9d21dbbcd485f2c8d277b046e2d8403149f67c3a.