jarun / googler

:mag: Google from the terminal
GNU General Public License v3.0
6.11k stars 529 forks source link

include alias inside shell completion #424

Closed CantoroMC closed 3 years ago

CantoroMC commented 3 years ago

I just decided to use googler, after being a fan of nnn. I have seen the shell alias provided in goggler_at but I think that instead of remembering and sourcing aliases, having shell completion providing those sites would be more handy. I use zsh and I have only a limited knowledge on his completion system. I have reported the site provided for -w and -N in googler_at in auto-completion/zsh/_googler, so now pressing Tab after the two flags provides the sites. Hope this is useful, I will take a look and use googler from here on and maybe I can further improve this.

jarun commented 3 years ago

Shell completions are for program options. Please have this locally. Some packagers install the completion scripts as well and all users may not prefer to have aliases.