jarun / imgp

:camera_flash: Fast batch image resizer and rotator
GNU General Public License v3.0
1.03k stars 50 forks source link

Hello there! #12

Closed bourdeau closed 7 years ago

bourdeau commented 7 years ago

Hello Jarun,

I'm sorry to contact you here but there is unfortunately no PM on Github.

I ended up on your package as I'm also trying to resize image using PIL and Multiprocessing Pool with Python 3.

And I was wondering: have you ever 'lost' images? By that I mean that some processes fail to resize and save the new resized image.

It happen to me on my project quite randomly and I can't figure out what is the problem. I always use the same images to run my test but it's not always the same which are missing. It's quite weird...

If by any chance you have any idea why I would gladly hear your advice (I'm new to Python).

I wish you a very nice day.

Pierre

jarun commented 7 years ago

Do you see this issue with imgp?

I use imgp on 1000s of images often. Haven't seen this so far.

In case this is related to your own utility, do you check the status of the resize operation before removing the original image? Probably you can also add a check that the destination image exists and is not 0 bytes in size.

bourdeau commented 7 years ago

Hi Jarun,

Tanks a lot for your answer. I resolved mt problem: I was stupidly creating a new Pool() in a for loop... Now it works just fine :)

Tanks again for your answer and your work helped me to solve my problem :+1:

jarun commented 7 years ago

Closing with the above comment.