Open vivianzheng404 opened 1 year ago
Apart from inline comments, the following are the general comments:
- Add author in new files as well as add @SInCE.
- Update the author with your name in all of the touched files.
- We need to align of code style/format. If needed I can provide one which has been originally used in the older releases.
- Update README.md for the addition of Postgres persistence layer. Currently, it mentions only MySQL implementation.
Reply:
Apart from inline comments, the following are the general comments:
- Add author in new files as well as add @SInCE.
- Update the author with your name in all of the touched files.
- We need to align of code style/format. If needed I can provide one which has been originally used in the older releases.
- Update README.md for the addition of Postgres persistence layer. Currently, it mentions only MySQL implementation.
Reply:
- I am curious about the reason for adding @SInCE
- Done
- Is the style/format referring to the formatter in this comment ? https://github.com/jas34/scheduledwf/pull/32/files#r1250801445 I am not aware, please elaborate.
- Done
This version is compatible to conductor-boot v3.13.5 Besides mySQL, additionally supports PostgreSQL for persistent storage