jas34 / scheduledwf

Schedule Conductor workflow is a scheduler as a service that runs in the cloud with Netflix conductor embedded in it. It runs as an extension module of conductor.
https://github.com/jas34/scheduledwf
Apache License 2.0
24 stars 16 forks source link

Deprecate IDGenerator_.java #35

Open jas34 opened 1 year ago

jas34 commented 1 year ago

While working on the PR with @vivianzheng404 on the PR - https://github.com/jas34/scheduledwf/pull/32, we realised that the conductor has changed IDGenerator from static class to a spring bean (Ref https://github.com/Netflix/conductor/pull/2910). For release-3.0.0 we have decided to go with a static class adapted in scheduledwf as IDGenerator.java (at scheduledwf-core/src/main/java/io/github/jas34/scheduledwf/utils/IDGenerator.java). This ticket will deprecate IDGenerator_ and we will move to consume IDGenerator bean from conductor-core. This ticket is being opened to implement after release-3.0.0. Refer to conversation - https://github.com/jas34/scheduledwf/pull/32/files#r1250839746