search

jascdk / Nilan_Homeassistant

Use your Home Assistant to control and read values from your Nilan air vent system
54 stars 25 forks source link

Revert "add landing page instead of nothing if nilan isnt connected" #17

Closed jascdk closed 4 years ago

jascdk commented 4 years ago

Reverts jascdk/Nilan_Homeassistant#15

@sveip Hi:) Would it be possible to add the landing page with a define, so the user is able to add or disable it? It removes the old json, which the system were capable of showing before.

I think I will try to revert it for now

sveip commented 4 years ago

There is a check if json is present, and in that case it should be as before. But probably a bug in the check if you don't get any json.

Peter

On Thu, Feb 13, 2020, 20:58 jascdk notifications@github.com wrote:

Merged #17 https://github.com/jascdk/Nilan_Homeassistant/pull/17 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jascdk/Nilan_Homeassistant/pull/17?email_source=notifications&email_token=ABLR4L2F7WQWSHFDIN3SI2DRCWQ5PA5CNFSM4KUZZJPKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWT5JXMI#event-3036322737, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLR4L5SS6PDHUQWTCV2S4TRCWQ5PANCNFSM4KUZZJPA .

jascdk commented 4 years ago

There is a check if json is present, and in that case it should be as before. But probably a bug in the check if you don't get any json. Peter …

Do you get some json response on your system?

sveip commented 4 years ago

I dont have it connected yet to my Nilan, so I havent been able to test it with real data. I added a comment to my PR, with some explanation, if you want you can test that and maybe post the results? Also if you would just post the JSON result you typically get when accessing the index html, that would be useful.

jascdk commented 4 years ago

As it is now I get something like this when accessing http://10.0.1.16/help and http://10.0.1.16/read/control (like an example) Skærmbillede 2020-02-16 kl 13 51 29 Skærmbillede 2020-02-16 kl 13 51 06

sveip commented 4 years ago

What do you get from http://10.0.1.16/ http://10.0.1.16/help ?

søn. 16. feb. 2020 kl. 13:53 skrev jascdk notifications@github.com:

As it is now I get something like this when accessing http://10.0.1.16/help and http://10.0.1.16/read/control (like an example) [image: Skærmbillede 2020-02-16 kl 13 51 29] https://user-images.githubusercontent.com/35434108/74604976-b395b880-50c3-11ea-9dd3-e4bad0a4a2ed.png [image: Skærmbillede 2020-02-16 kl 13 51 06] https://user-images.githubusercontent.com/35434108/74604979-b55f7c00-50c3-11ea-8f8d-39d29e4968aa.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jascdk/Nilan_Homeassistant/pull/17?email_source=notifications&email_token=ABLR4L36LEWETXA5F3EX2JDRDEZMVA5CNFSM4KUZZJPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4GB3A#issuecomment-586703084, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLR4LZJBJDANGAVCZIIBGLRDEZMVANCNFSM4KUZZJPA .

sveip commented 4 years ago

If you want, you can test this version: https://github.com/sveip/Nilan_Homeassistant/blob/master/nilan_code/nilan_code.ino

It should hopefully give the info page when nothing is present in the json, and the json itself it if is.

søn. 16. feb. 2020 kl. 14:26 skrev Peter Sveistrup <petersveistrup@gmail.com

:

What do you get from http://10.0.1.16/ http://10.0.1.16/help ?

søn. 16. feb. 2020 kl. 13:53 skrev jascdk notifications@github.com:

As it is now I get something like this when accessing http://10.0.1.16/help and http://10.0.1.16/read/control (like an example) [image: Skærmbillede 2020-02-16 kl 13 51 29] https://user-images.githubusercontent.com/35434108/74604976-b395b880-50c3-11ea-9dd3-e4bad0a4a2ed.png [image: Skærmbillede 2020-02-16 kl 13 51 06] https://user-images.githubusercontent.com/35434108/74604979-b55f7c00-50c3-11ea-8f8d-39d29e4968aa.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jascdk/Nilan_Homeassistant/pull/17?email_source=notifications&email_token=ABLR4L36LEWETXA5F3EX2JDRDEZMVA5CNFSM4KUZZJPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4GB3A#issuecomment-586703084, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLR4LZJBJDANGAVCZIIBGLRDEZMVANCNFSM4KUZZJPA .

jascdk commented 4 years ago

http://10.0.1.16/ gives nothing else than this: Skærmbillede 2020-02-16 kl 16 33 04

http://10.0.1.16/help gives the same as before

sveip commented 4 years ago

it seems "group" is always there, so my latest commit should then in theory work.

søn. 16. feb. 2020 kl. 16:33 skrev jascdk notifications@github.com:

http://10.0.1.16/ gives nothing else than this: [image: Skærmbillede 2020-02-16 kl 16 33 04] https://user-images.githubusercontent.com/35434108/74607550-04b0a700-50da-11ea-8bb8-c8d07d65f4ee.png

http://10.0.1.16/help gives the same as before

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jascdk/Nilan_Homeassistant/pull/17?email_source=notifications&email_token=ABLR4LZLT2R7LKJGBQFLT6DRDFMFNA5CNFSM4KUZZJPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4KFBY#issuecomment-586719879, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLR4L35JJDZCODEVPHR37TRDFMFNANCNFSM4KUZZJPA .

jascdk commented 4 years ago

When are you getting your system up and running? It would be nice to know what you see at your system:)

sveip commented 4 years ago

It depends, the front panel on my Nilan Compact S is really stuck on there, so not sure how I'll be able to access the board for the modbus.

man. 17. feb. 2020 kl. 16:46 skrev jascdk notifications@github.com:

When are you getting your system up and running? It would be nice to know what you see at your system:)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jascdk/Nilan_Homeassistant/pull/17?email_source=notifications&email_token=ABLR4LZAZ4XJSVBG2JW7ITLRDKWMNA5CNFSM4KUZZJPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL63RZA#issuecomment-587053284, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLR4L2K74DKJLHXFNFC4C3RDKWMNANCNFSM4KUZZJPA .

jascdk commented 4 years ago

okay - instead of using the HTML page i thought of taking the given values out via json format, so the wifi connected / not connected - Ip-Address, Mqtt connected / not connected and so forth would be able to read in json format ? I could maybe make a "status" group . Is this a bad idea or?