jasdumas / shinyGEO

Gene Expression Omnibus Analysis with Shiny :microscope:
http://jasdumas.com/shinyGEO/
Other
41 stars 47 forks source link

Pre-submission tasks to rOpenSci #83

Open jasdumas opened 7 years ago

jasdumas commented 7 years ago

To do list

checking package dependencies ... ERROR
Packages required but not available: ‘limma’ ‘affy’

See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
manual.
R CMD check results
1 error  | 0 warnings | 0 notes

R CMD check succeeded
jasdumas commented 7 years ago

package were not installed on my local machine. I also did an update of the Bioconductor installer

https://www.bioconductor.org/install/

jasdumas commented 7 years ago

@gdancik wanted to ping you on these current things i'm working on! 😄

Status: 1 NOTE
checking installed package size ... NOTE
  installed size is 54.5Mb
  sub-directories of 1Mb or more:
    shiny-apps  54.5Mb

See
  ‘/Users/jasminedumas/Desktop/R-directory/shinyGEO.Rcheck/00check.log’
for details.

R CMD check results
0 errors | 0 warnings | 1 note 

R CMD check succeeded
gdancik commented 7 years ago

Thanks for the update and I'm excited to see the you are making progress on this. For the update_GEOdata() function, right now that functionality is in bash scripts which will be shell / OS dependent. We have (or at least had) versions working on Mac and Linux but they are slightly different versions. To include this in the R package, you could implement this as a pure R function using RCurl.

jasdumas commented 7 years ago

@gdancik whenever you get a chance, please feel free to review my last commit which added the updateGEOdata() function here: https://github.com/jasdumas/shinyGEO/blob/master/R/updateGEOdata.R which uses the rvest and readr packages.

gdancik commented 7 years ago

This is amazing! Great job! I will merge this soon with the other shinyGEO so we have this functionality in R.