search

jaseg / python-mpv

Python interface to the awesome mpv media player
https://git.jaseg.de/python-mpv.git
Other
532 stars 67 forks source link

mpv.py: change mpv_detach_destroy to mpv_destroy #195

Closed ghost closed 2 years ago

ghost commented 2 years ago

because mpv_detach_destroy is deprecated and will be deleted in mpv 0.35.0

dfaker commented 2 years ago

I was just about to offer this myself, also:

mpv_get_sub_api 31a34,39 mpv_opengl_cb_draw mpv_opengl_cb_init_gl mpv_opengl_cb_render mpv_opengl_cb_report_flip mpv_opengl_cb_set_update_callback mpv_opengl_cb_uninit_gl 41a50 mpv_resume 48a58 mpv_suspend

Are completely dropped, mpv_opengl_cb* calls are safely behind a guard here but cannot be used now.

dfaker commented 2 years ago

@jaseg do we plan not to jump versions to 2 or just want to persue a more structured removal of the dropped apis? I'd be happy to offer a more structured mpv-1+mpv-2 dynamic loading and api disabling mechanism as long as I know it's the path you'd like to go down.

jaseg commented 2 years ago

With the recent addition of async command support, and future-based APIs for the wait_for_{event,property} methods on main I think it may be time to bump the major version. I'll have a look through the API to try to figure out if anything else is in need of an update as well.

It would be awesome if you could submit a PR removing the libmpv function wrappers that you are sure are deprecated or that will be deprecated in the near future. It seems even debian stable is on mpv 0.30.0 now, so I'm fine with removing the opengl_cb functions. I'll update the README with examples using the render API instead.

dfaker commented 2 years ago

It'd be my pleasure, thanks!