jaseknighter / flora

L-systems sequencer and bandpass filtered sawtooth engine for monome norns
GNU General Public License v3.0
47 stars 6 forks source link

Plant drawing issues after 231114 update? #7

Open m-r-m-s opened 10 months ago

m-r-m-s commented 10 months ago

I was using the flora script and noticed some "artifacts" on the topmost portion of the plant screen. Looks to be on the drawing area of the screen just below the banner text description. Wondering if this is a result of the screen overhaul or maybe I am just now noticing these "tendrils" :) I'm fairly certain I am on the latest version of flora (2.0?) but I often get the "update failed, unstaged changes" message when I update in maiden. I've just been manually installing new flora versions via my Mac and mounting the Norns as a networked drive. Thanks as always for this amazing script🌿

m-r-m-s commented 10 months ago

image This is on the observe page. After modifying the plants it looks like they're becoming disconnected & then leave some artifacts after changing the plant type rather than just the artifacts mentioned earlier...

jaseknighter commented 10 months ago

thank you for the report. i will investigate sometime in the next few days. <3

edit: i did a quick check and this issue didn't appear for me. @m-r-m-s, i wonder if you are on the latest flora version?

m-r-m-s commented 10 months ago

Ah, ok. I thought I was current...hmmmnnnn. The title screen on flora says 2.0 and in matron, i have the update button and the string (5be835c). Is that the commit (version of flora)? Different from when I reported the issue the other day, now when I just tried to update, Matron now says "the latest version of Flora is already installed". Still haven't figured out the "update failed..." conundrum that happens there sometimes... I can delete Flora manually later today and report back. I also have a bunch of mods enabled so I could also try to disable them all too and test again before re-installing the script. Will report back. Thanks 🙌

m-r-m-s commented 10 months ago

Ok, disabled all mods and reinstalled Flora. It seems like the issue is happening with my 16n faderbank when Plants> instruction, angle, generation are mapped. Specifically plant1&2generation throw the following error in in matron when either of those plant generation faders are moved:

lua: 
/home/we/norns/lua/core/clock.lua:64: /home/we/norns/lua/lib/musicutil.lua:630: attempt to perform arithmetic on a nil value (local 'note_num')
stack traceback:
    [C]: in function 'error'
    /home/we/norns/lua/core/clock.lua:64: in function 'core/clock.resume'
jaseknighter commented 10 months ago

thank you for the sleuthing! i will investigate in the next couple of days.