jash-kothari-forks / libtorrent

Automatically exported from code.google.com/p/libtorrent
Other
0 stars 0 forks source link

make_magnet_uri should work on torrents that don't have metadata yet. #426

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I think make_magnet_uri should work even when the torrent doesn't have metadata 
(ie it was started as a magnet link and hasn't downloaded the metadata from the 
swarm). All the basic information are available to return a valid magnet uri.

This will allow for GUI clients (like qbittorrent) to offer the user a "copy 
magnet uri" menu item even for magnet files.

Original issue reported on code.google.com by hammered...@gmail.com on 2 Mar 2013 at 10:32

GoogleCodeExporter commented 9 years ago
I agree. thanks for pointing this out.

Original comment by arvid.no...@gmail.com on 5 Mar 2013 at 5:10

GoogleCodeExporter commented 9 years ago

Original comment by arvid.no...@gmail.com on 5 Mar 2013 at 5:10

GoogleCodeExporter commented 9 years ago
As far as I can tell, the make_magnet_uri() that takes a torrent_handle 
supports this

Original comment by arvid.no...@gmail.com on 5 Mar 2013 at 5:45

GoogleCodeExporter commented 9 years ago
As far as I can tell, the make_magnet_uri() that takes a torrent_handle 
supports this. are you sure this isn't a limitation in qBitTorrent?

Original comment by arvid.no...@gmail.com on 5 Mar 2013 at 6:05

GoogleCodeExporter commented 9 years ago
I am sorry that I wasted your time. You were right, the code was checking for 
has_metadata() on the handle and skipped make_magnet_uri(). I totally 
overlooked it.

Original comment by hammered...@gmail.com on 5 Mar 2013 at 9:13

GoogleCodeExporter commented 9 years ago

Original comment by arvid.no...@gmail.com on 5 Mar 2013 at 10:28