jash-kothari-forks / libtorrent

Automatically exported from code.google.com/p/libtorrent
Other
0 stars 0 forks source link

peer_blocked_alert is fired even when there isn't an IP filter set. #464

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I used RC_0_16 and I extended the simple_client.cpp to read alerts.
Even if I don't set an IP filter I get a peer_blocked_alert. I am not sure but 
maybe the peer_blocked_alert should be a peer_ban_alert instead.

How to test? Compile the code below and try to download a torrent that would 
normally have peers with corrupt data(ie a new american series ep release).

source code: http://pastebin.com/4sNQiN1r

Original issue reported on code.google.com by hammered...@gmail.com on 16 Apr 2013 at 3:09

GoogleCodeExporter commented 8 years ago
There are many reasons peers are blocked. peers that are banned are not allowed 
to connect again, so they're blocked. This is probably the case you're seeing. 
There are other ways of blocking peers, other than the ip filter. For instance, 
if you disable utp or tcp, if you're running over i2p and a non-i2p connection 
tries to connect, if you're using a proxy and disallow connections that 
circumvent it, etc.

This seems more like a question than a bug report.

The peer_banned alert is posted when a peer is banned, not when that same peer 
is subsequently blocked because it's banned.

Original comment by arvid.no...@gmail.com on 16 Apr 2013 at 10:59

GoogleCodeExporter commented 8 years ago
Then consider this as a bug report for the documentation. The docs state that 
the peer_blocked alert will fire only when the IP filter contains the address.

Furthermore, as you can see from the code above, I haven't disabled anything 
nor do I run through a proxy. I didn't use i2p either. I got several 
peer_blocked alerts and none peer_ban alert. So there is either a bug that 
never fires a peer_ban or peer_blocked was fired for a reason not mentioned 
above.

Original comment by hammered...@gmail.com on 17 Apr 2013 at 4:39

GoogleCodeExporter commented 8 years ago

Original comment by arvid.no...@gmail.com on 19 Apr 2013 at 7:54

GoogleCodeExporter commented 8 years ago
fixed in [8331].

Original comment by arvid.no...@gmail.com on 24 Apr 2013 at 4:25

GoogleCodeExporter commented 8 years ago
Issue 497 has been merged into this issue.

Original comment by arvid.no...@gmail.com on 7 Sep 2013 at 9:04