fix for issue #4205 - Githubissues

jashkenas / backbone

Give your JS App some Backbone with Models, Views, Collections, and Events

http://backbonejs.org

MIT License

28.09k stars 5.39k forks source link

Closed prma85 closed 2 years ago

prma85 commented 5 years ago

Change the model verification to fix the issue #4205

jgonggrijp commented 2 years ago

While I agree #4205 must be solved, I am rejecting this for the following reasons:

No test is added, so there is no clear evidence that this change actually solves the problem.
The added !existing condition is void, because the if (add) is already in the else branch of the previous if (existing). This makes it implausible that the problem is actually being solved.