jashkenas / backbone

Give your JS App some Backbone with Models, Views, Collections, and Events
http://backbonejs.org
MIT License
28.1k stars 5.39k forks source link

Community question: who is interested in reviewing my pull requests? #4268

Open jgonggrijp opened 1 year ago

jgonggrijp commented 1 year ago

I have taken on the burden of maintaining Backbone. I also happen to believe that ideally, each code change should be reviewed by somebody other than the author.

When somebody else submits a pull request (please do!), I can obviously review it. When I submit a pull request myself (which I expect to do a lot), it is not so obvious who might review it.

So far, I've been blindly @mentioning people who I thought (or hoped) might be interested in reviewing. I now feel that this pattern is not sustainable; I will miss people who are interested and annoy people who are not. Instead, I would like to actually know which people are interested in reviewing.

Of course, I'm hoping that expert contributors are interested, but non-expert reviewers are welcome, too. The more reviewers, the better.

Text replies for other reasons also welcome, of course.

For the last time, a blind CC (sorry): @paulfalgout @ogonkov @GammaGames @chkpnt @jcbrand @karloscarweber @Rayraz @taburetkin @alanhamlett

Rayraz commented 1 year ago

I've been following this repo for many years, but my last backbone maintenance project wound down a few months ago and my in-depth familiarity with the code-base has faded over time. I enjoy thinking through conceptual decisions about features and the direction of the API though and those don't always require the deepest familiarity with the source code. Feel free to @mention me from time to time if you feel like you are short on this type of input you expect reduced familiarity with the source won't be too much of a disadvantage.

GammaGames commented 1 year ago

I haven't really dug into the code, but I do use the library regularly for work and would be happy to do the occasional review! Glad to see some organization going on and look forward to progress πŸ™‚

paulfalgout commented 1 year ago

Pretty invested in Bb and Marionette. You can put me on things to review. I'm generally available at some time during the week for reviews. But it's difficult to give exact estimates over time. My day job supports me working on the OSS we use, but it's somewhat dependent on workload.