jgonggrijp
commented
3 months ago Thank you for reporting this. I was able to reproduce this with the following snippet of code:
var attrs = {id: 1, fruit: 'banana'};
var m = new Backbone.Model(attrs);
m.on('all', console.log);
m.set(attrs);
// Logs "changeId" to the console, plus event payload.Before even trying that, I already took a peek at the code and immediately got a suspicion what might be causing this. The event is triggered here:
The condition of the if goes this.idAttribute in attrs, which checks whether the idAttribute is specified in the attributes passed to set. However, that does not take into account whether the specified value is actually different from the existing id. A more appropriate check would be _.contains(changes, this.idAttribute).
One other thing I noticed while looking at the code: changeId currently triggers even if the option silent: true is passed. Line 526 (from the snippet above) should probably be made conditional on !silent.
Noodlex
Affected component
The set function of backbone model
Expected behavior
Trigger "changeId" if the changeId is different of previous
Actual behavior
Always trigger "changeId"
Relevant documentation
No response
Software stack
Related issues, prior discussion and CCs
No response
Error
No response
Steps to reproduce
Additional information
No response
Suggested solution(s)
No response
Other remarks
No response