jashkenas / underscore

JavaScript's utility _ belt
https://underscorejs.org
MIT License
27.33k stars 5.53k forks source link

Fix order of assertion parameters #2825

Closed ppenicka closed 4 years ago

ppenicka commented 4 years ago

In the unit test for _.max() several assertions had the 'actual' and 'expected' parameters swapped. Fixed it yields the same result, but looks more consistent and potentially less confusing (a colleague actually got confused by this and we spent some time figuring out if there's a specific reason for them being swapped, concluding there isn't - hence this PR).

jashkenas commented 4 years ago

Thanks for the cleanup!