search

jashkenas / underscore

JavaScript's utility _ belt
https://underscorejs.org
MIT License
27.33k stars 5.53k forks source link

_.max() should compare between numbers #2896

Closed anderlaw closed 3 years ago

anderlaw commented 3 years ago

As mentioned in the underscore document, _.max function should compare items by numbers only

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 95.197% when pulling af2f9190b3a4c6e0ed3725285d3a37d4b1ff8101 on anderlaw:master into c9b4b63fd08847281260205b995ae644f6f2f4d2 on jashkenas:master.

anderlaw commented 3 years ago

Thanks for the response, I'd like to do that

jgonggrijp commented 3 years ago

Congratulations with your first contribution to Underscore, @anderlaw!