Documentation _.unescape uses wrong hex code

jashkenas / underscore

JavaScript's utility _ belt

https://underscorejs.org

MIT License

27.3k stars 5.53k forks source link

Documentation _.unescape uses wrong hex code #2925

Closed MalteSaup closed 3 years ago

MalteSaup commented 3 years ago

In the documentation you use &#96 ; for the ` Symbol, wich is the correct Decimal Code, but .unescape seems to only work with the hex code &#x60 ; wich also is returned from the .escape function

jgonggrijp commented 3 years ago

Thanks for bringing this to our attention, @MalteSaup! If you like, please feel welcome to submit a PR to fix the documentation and get the credit for it.

itsdeekay commented 3 years ago

Hi @jgonggrijp , I have started contributing to open source. Could you assign this issue to me so that I can contribute?

jgonggrijp commented 3 years ago

@itsdeekay Thanks for stepping up! You can contribute without being assigned, but I don't mind assigning people so there you are.

itsdeekay commented 3 years ago

Thanks @jgonggrijp , I have created a pull request for the same.