search

jashkenas / underscore

JavaScript's utility _ belt
https://underscorejs.org
MIT License
27.3k stars 5.53k forks source link

Fixed documentation typos for issue #2925 #2934

Closed itsdeekay closed 3 years ago

itsdeekay commented 3 years ago

Hi

I have fixed the typo as suggested in issue resolves #2925 . Please review it and merge it.

itsdeekay commented 3 years ago

I have performed the steps as you mentioned except the fourth which was giving error so I did this instead git push origin issue-2925 --force and created a pull request. Seems like commit history is still there. Is there something I missed?

jgonggrijp commented 3 years ago

GitHub sometimes still shows the old commits for a while after you've updated the branch by force-push. No worries, it seems everything went the way it should. You can see this for yourself in the "Commits" and "Files changed" tabs.

Merging now. Congratulations with your first contribution!

itsdeekay commented 3 years ago

Thanks @jgonggrijp for your guidance. I hope to work on more problems. If you have any open work where I can work please let me know.

jgonggrijp commented 3 years ago

@itsdeekay You are welcome to work on any open issue that doesn't have the "contrib", "breaking change" or "fixed" label. (If it does have one of those labels, you're welcome too, but I'm much more likely to reject the PR.)

In addition, if you run into anything while using Underscore yourself, feel free to submit a new issue ticket and/or submit a PR to address it.

itsdeekay commented 3 years ago

That's the case, most of the issues are related to these flags only and others are already assigned or are discussion pending. I am open to work on other open source projects if there is requirement. Thanks

jgonggrijp commented 3 years ago

That still leaves at least #2909, #2853 and #2780. If you're up to the challenge, you can also ignore my assignment and try your hand at #2927. If none of that suits you, I can also use help in https://github.com/documentcloud/underscore-contrib, for example https://github.com/documentcloud/underscore-contrib/issues/133 or any of the issues with a "docs" label.

itsdeekay commented 3 years ago

Thanks, created pull request for #2780