search

jashkenas / underscore

JavaScript's utility _ belt
https://underscorejs.org
MIT License
27.3k stars 5.53k forks source link

Mobile responsive and more readability #2935

Closed itsdeekay closed 2 years ago

itsdeekay commented 3 years ago

Tried to resolved issue #2780 to make documentation site mobile responsive and change font little bit for better readability.

jgonggrijp commented 3 years ago

Hey @itsdeekay thanks for getting back here!

I'm going to review this soon, but right now, I can't easily preview the code on a mobile device because Statically.io has changed its policies. You now need to opt in to the HTML service. Would you mind doing that? If you fork this gist: https://gist.github.com/jgonggrijp/be0da2723ee944d5746a81bdfe3c6bac, I can take it from there (the second and final step is a tweet to the maintainer of Statically.io). The whole "procedure" is explained over here: https://statically.io/docs/using-staticzap/.

jgonggrijp commented 2 years ago

Just realized I could do a workaround by copying the branch to my own fork. I reviewed again based on the following comparison: before, after. I'm happy with the end result. I'll just restore some of the whitespace changes, which in my opinion don't need to be there, and then merge this branch.

Thanks for your contribution, @itsdeekay!