search

jashkenas / underscore

JavaScript's utility _ belt
https://underscorejs.org
MIT License
27.29k stars 5.53k forks source link

Test: Use same QUnit version in CI as on website #2951

Closed Krinkle closed 2 years ago

Krinkle commented 2 years ago

Follows-up c9b4b63fd08847281260205b995ae644f6f2f4d2 and 13f71bc9711b3617dd0fd5f1f085655df8505cf8.

Contrary to the commit message, it actually restored the older QUnit 2.6, and not the newer QUnit 2.10 version from package.json.

The oldest Node.js LTS is currently Node 12. The latest QUnit 2.18 supports Node 10+. This repo currently has a Node 8 CI job.

While at it, update both to 2.10.1, the last version to support Node 8 (changelog), and pin it to avoid "npm install" from expanding it and saving it to the lock file which Node 8 would see. Hopefully also avoiding e.g. using a newer method which would then fail on the website version later.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 95.217% when pulling 7312895ae1dce8e87c12600f97190a87aaec8221 on Krinkle:same-version into 596a7f2d63bbd8a55d07ee18b804619d727e779f on jashkenas:master.