search

jashkenas / underscore

JavaScript's utility _ belt
https://underscorejs.org
MIT License
27.29k stars 5.53k forks source link

Run patch-package only on development (test+publish) #2972

Closed iglosiggio closed 1 year ago

iglosiggio commented 1 year ago

I'm not sure this is the correct fix (don't have the setup to do js development here) but it looks like a viable direction.

This should help with #2967 #2968 #2969 #2970 #2971

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 95.024% when pulling becb32abeef415c8f7c89100c5efc6457afb9d75 on iglosiggio:patch-1 into 66ee70d746399b3446a700492bc62f4117d4a21b on jashkenas:master.

jgonggrijp commented 1 year ago

Thanks for the patch and sorry for the trouble I have caused. I'm going to hotfix this first by simply throwing the postinstall script out of the package.json; I'm not sure what is the right place to run patch-package yet, but it is not required for end users in any case.

jgonggrijp commented 1 year ago

I chose a slightly different, but similar approach: run it before building the annotated sources, rather than before running the tests. That's because the patched package is docco, which we use for the annotated sources. Thanks again for the fast action!

jgonggrijp commented 1 year ago

(Oh, and also #2974 was merged first by @jashkenas, while I was doing the same thing locally.)

iglosiggio commented 1 year ago

I chose a slightly different, but similar approach: run it before building the annotated sources, rather than before running the tests. That's because the patched package is docco, which we use for the annotated sources. Thanks again for the fast action!

Thank you for your swift resolution of the issue! <3