search

jashkenas / underscore

JavaScript's utility _ belt
https://underscorejs.org
MIT License
27.29k stars 5.53k forks source link

Hotfix for broken builds #2974

Closed paulsmithkc closed 1 year ago

paulsmithkc commented 1 year ago

patch-package is a dev dependency and should not be required by users of underscore.js

This hotfix removes the postinstall script which is causing multiple build failures across the ecosystem.

See #2967, #2968, #2969, #2970, #2971, #2973

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 95.024% when pulling 2edcdc18b64db878b887a6047300e724995481e4 on paulsmithkc:patch-1 into 66ee70d746399b3446a700492bc62f4117d4a21b on jashkenas:master.

paulsmithkc commented 1 year ago

@jashkenas bump

jcowley commented 1 year ago

Thank you!

jashkenas commented 1 year ago

Will publish as 1.13.6 in a few minutes, hang tight.

jgonggrijp commented 1 year ago

@jashkenas I think I outran you.

jgonggrijp commented 1 year ago

With publishing to NPM, at least.

jgonggrijp commented 1 year ago

I'm preparing a website update now, please let me know where you stand.

jashkenas commented 1 year ago

Thanks for jumping in @jgonggrijp — I'll leave things in your hands as to avoid crossing wires. (npm had me locked out on this new laptop, so thanks for pushing the button)

jgonggrijp commented 1 year ago

Alright I'll finish the job.