Mixin failure on 1.17 (21w19a)

jaskarth / databreaker

removes DataFixerUpper

GNU Lesser General Public License v3.0

18 stars 10 forks source link

Mixin failure on 1.17 (21w19a) #8

Closed Leo40Git closed 3 years ago

Leo40Git commented 3 years ago

[main/FATAL] (mixin) Mixin apply failed databreaker.mixins.json:fix_log_spam.MixinLevelStorageClient -> net.minecraft.world.level.storage.LevelStorage:
org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException
PRIVATE @Overwrite method createLevelDataParser in databreaker.mixins.json:fix_log_spam.MixinLevelStorageClient cannot reduce visibiliy of PUBLIC target method

Seems like method visibility got changed here.

(also I just noticed the error misspelled "visibility" lol)

Leo40Git commented 3 years ago

Fixed by c0166ee9990b98191f80058e11ce17fe25278da4.

Ristovski commented 3 years ago

@Leo40Git This broke Jitpack builds with > You are using an outdated version of Java (8). Java 16 or higher is required. https://jitpack.io/com/github/SuperCoder7979/databreaker/0.2.7/build.log

Leo40Git commented 3 years ago

That's another issue, a jitpack.yaml file needs to be added.

Ristovski commented 3 years ago

Whoops, didn't notice you weren't the one who pushed that commit. My bad.