Move Uint63 to its own library

jasmin-lang / jasmin

Language for high-assurance and high-speed cryptography

MIT License

271 stars 55 forks source link

Move Uint63 to its own library #807

Closed vbgl closed 6 months ago

vbgl commented 6 months ago

There are two implementations:

native, the default one, that assumes that build and host environments have same word sizes;
js, that only works with 32-bit host (suitable when compiling the Jasmin compiler to javascript)

eponier commented 6 months ago

I find it strange that we have to do such a hack. I discussed with Maxime who suggested to raise a question on the Zulip, what I did here. If the discussion does not converge, then I'll merge the PR, but I hope there is a cleaner solution.

vbgl commented 6 months ago

Why do you call this a hack? I think what is in this PR is no more dirty than what is currently implemented.

eponier commented 6 months ago

It is a hack not in the sense that it is dirty, but in the sense that I have the feeling that it should work directly. Anyway, nothing emerged from Zulip, so I'm merging.