jasminb / jsonapi-converter

JSONAPI-Converter is a Java/Android library that provides support for working with JSONAPI spec
Apache License 2.0
272 stars 81 forks source link

allow alternate typenames and relationships #232

Open championswimmer opened 4 years ago

championswimmer commented 4 years ago

This is to handle the case, where some server side serialization libraries might mixup singular and plural type names.

An example are these two nodejs libraries

https://www.npmjs.com/package/jsonapi-serializer - produces plurals https://www.npmjs.com/package/json-api-serializer - produces singulars

We can now support multiple types

@Type({"comments", "comment"})
public class Comment {
    @Id
    private String id;
    private String body;
    // ...
}

Signed-off-by: Arnav Gupta arnav@codingblocks.com

championswimmer commented 4 years ago

@aggarwalpulkit596

championswimmer commented 4 years ago

Hey @jasminb could you take a look at this please :)

Thanks

jasminb commented 3 years ago

@championswimmer This looks like a useful improvements, however instead of changing the Type annotation to an array and breaking things for all of the users, I would rather add another attribute to the annotation, eg. alternativeNames which could than be used by people who need it and all existing users don't need to change anything.

championswimmer commented 3 years ago

@championswimmer This looks like a useful improvements, however instead of changing the Type annotation to an array and breaking things for all of the users, I would rather add another attribute to the annotation, eg. alternativeNames which could than be used by people who need it and all existing users don't need to change anything.

Well, ok that makes a lot more sense !