Open championswimmer opened 4 years ago
@aggarwalpulkit596
Hey @jasminb could you take a look at this please :)
Thanks
@championswimmer This looks like a useful improvements, however instead of changing the Type
annotation to an array and breaking things for all of the users, I would rather add another attribute to the annotation, eg. alternativeNames
which could than be used by people who need it and all existing users don't need to change anything.
@championswimmer This looks like a useful improvements, however instead of changing the
Type
annotation to an array and breaking things for all of the users, I would rather add another attribute to the annotation, eg.alternativeNames
which could than be used by people who need it and all existing users don't need to change anything.
Well, ok that makes a lot more sense !
This is to handle the case, where some server side serialization libraries might mixup singular and plural type names.
An example are these two nodejs libraries
https://www.npmjs.com/package/jsonapi-serializer - produces plurals https://www.npmjs.com/package/json-api-serializer - produces singulars
We can now support multiple types
Signed-off-by: Arnav Gupta arnav@codingblocks.com