jasminb / jsonapi-converter

JSONAPI-Converter is a Java/Android library that provides support for working with JSONAPI spec
Apache License 2.0
272 stars 81 forks source link

Proguard issues with jsonapi-converter when Android project to targets java 17 #261

Open RabieJradi opened 1 year ago

RabieJradi commented 1 year ago

I've encountered an issue with this library when using Proguard due to some incompatibility with the current dependency version of jackson-databind after upgrading my Android project to use Gradle 8 (which requires targeting java 17).

I get the following Proguard errors:

Missing class java.beans.ConstructorProperties (referenced from: void com.fasterxml.jackson.databind.ext.Java7SupportImpl.<init>() and 2 other contexts)
Missing class java.beans.Transient (referenced from: void com.fasterxml.jackson.databind.ext.Java7SupportImpl.<init>() and 1 other context)

Simply masking the errors via the following Proguard rules doesn't work. It will allow the project to compile but then crash during runtime

-dontwarn java.beans.ConstructorProperties
-dontwarn java.beans.Transient

I believe this incompatibility will be fixed if the dependency of jackson-databind in this project is updated to use [latest version].(https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind/2.15.0)

jasminb commented 10 months ago

Hello @RabieJradi, version of databind is upgraded in #264 and is part of 0.13 release, please give it a spin and close the issue if ok.