search

jasmine-contrib / grunt-jasmine-node

Grunt task for running jasmine-node
MIT License
67 stars 99 forks source link

Changed the dependency of jasmine-node #46

Closed srosca closed 9 years ago

srosca commented 10 years ago

versions prior to 1.14.1 have problems with jasmine reporters

4kochi commented 10 years ago

+1

madtrick commented 10 years ago

+1 on this

cstephe commented 10 years ago

+1

ljharb commented 10 years ago

This is now fixed as of jasmine-node 1.14.5 - you should upgrade to ~1.14.5 instead. (don't use ^, as that breaks older nodes)

srosca commented 10 years ago

Changed to ~1.14.5 as suggested by @ljharb so it doesn't break on older nodes

ljharb commented 10 years ago

yay thanks

srosca commented 10 years ago

@s9tpepper & @creynders Can you look into this please?

cesine commented 10 years ago

+1

gareth-instil commented 10 years ago

It would be great to get this change in soon.

markstos commented 10 years ago

+1

This issue was causing a basic use of "grunt" to fail in another project.

menzer commented 10 years ago

+1, this is breaking all the things

menzer commented 10 years ago

@creynders @s9tpepper Can we please get this merged, or get an update on what's needed? Is this project still maintained? Thanks for any word you can give!

lennym commented 10 years ago

Would like to add my voice to support for this as I'm also suffering from the issues in #46

@creynders @s9tpepper If you're not supporting this project anymore, would you mind passing it on to someone who would?

creynders commented 10 years ago

@menzer @lennym Hey, sorry for not getting back, I didn't realize you mentioned me. Anyway, TBH I haven't contributed to grunt-jasmine-node at all. A year or two ago there were 3 almost-the-same-but-not-100% grunt-jasmine projects and we decided to group them. Mine was one of them, hence my organization membership.

Just a very long-winded way to say: I don't know this project and can't help, sorry.

@s9tpepper your call.

lennym commented 10 years ago

@creynders Fair enough. I appreciate you haven't had anything to do with this, just that @s9tpepper seems to have gone very quiet (no activity since March) so you were our best hope of getting this merged.

As it is, as a stopgap, and mostly for my own purposes, I've forked the code, included @srosca's commits, and published as grunt-jasmine-node-new@0.3.0. If anyone picks up this repo/package and starts actively maintaining it again then I'll happily close that down and point people back here. /cc @menzer

https://www.npmjs.org/package/grunt-jasmine-node-new

srosca commented 10 years ago

@s9tpepper If you need any help with this project I have some time.

shawnburke commented 10 years ago

+1 please merge this...totally broken without it, annoying to fork just for this.

dtothefp commented 10 years ago

Haaa...just did the same thing. This is very annoying. I also added a timeout option because for some reason applying the timeout in the tests themselves wasn't working