search

jasmine-contrib / grunt-jasmine-node

Grunt task for running jasmine-node
MIT License
67 stars 99 forks source link

use caret for jasmine-node dependency #51

Closed hereandnow closed 9 years ago

hereandnow commented 10 years ago

according to this issue jasmine-node threw errors when using a new version of jasmine-reporters. they downgraded their dependency to only use 1.x.x versions

this pull request just upgrades the dependency to jasmine-node to the current version + uses a caret instead of a tilde. that means that all minor upgrades (and not just patches) of jasmine-node will be automatically installed in the future.

if you are not comfortable using the caret (i know their a pro's and con's), please at least upgrade the jasmine-node-version

TheJefe commented 10 years ago

FWIW, I tested this change locally, and I use junit reporting, and this looks good to me.

Mergeable?

reimerp commented 9 years ago

run into the same issue and fixed it the same way using a corrected version of jasmine-node (1.14.5)

+1 for merge.