search

jasmine / jasmine-browser-runner

Serve and run your Jasmine specs in a browser
50 stars 25 forks source link

npx jasmine-browser-runner runSpecs doesn't use the port from the configuration file #21

Closed DobromirZlatkov closed 2 years ago

DobromirZlatkov commented 2 years ago

https://github.com/jasmine/jasmine-browser-runner/blob/69a18960391d5c302540eefe573a048f2c3e618a/index.js#L79

Most of the CSS, js, and static content for my tests are served from a third-party server, which has a specific CORS configuration, and every time I run the tests I need them to run on the same PORT. There is a "port" option in the jasmine-browser.json but it works only for the "npx jasmine-browser-runner serve" command and not working for "npx jasmine-browser-runner runSpecs". Can you update the code above to read the port from the configuration if is set?

sgravrock commented 2 years ago

Having the runSpecs command support the port option sounds like a good feature to have. I'd be happy to review a pull request that adds it.

DobromirZlatkov commented 2 years ago

I can't push to this repository (403), so I won't be able to create a pull request. Can you give me access or someone else may handle this?

sgravrock commented 2 years ago

Like most OSS projects, we only give direct write access to certain people. This doc explains how to set up a pull request. Basically you need to fork the repo, push your work up to your fork, and then open a PR from there.