search

jasmine / jasmine-browser-runner

Serve and run your Jasmine specs in a browser
49 stars 23 forks source link

Fix support for absolute paths in srcDir and specDir #50

Closed joeyparrish closed 6 months ago

joeyparrish commented 6 months ago

Instead of path.join(projectBaseDir, srcDir), we should use path.resolve(projectBaseDir, srcDir). Where join() will always join paths, resolve() will resolve relative paths relative to the previous argument, but leave absolute paths alone.

Closes #15

joeyparrish commented 6 months ago

I checked that the new test case fails without the fix (converting path.join to path.resolve every time projectBaseDir is involved), but passes with the fix. Please take a look!

sgravrock commented 6 months ago

Thanks!