search

jasmine / jasmine-gem

Jasmine ruby gem
682 stars 275 forks source link

rake jasmine:ci a bit too helpful? #181

Closed dentarg closed 10 years ago

dentarg commented 10 years ago 
$ rake jasmine:ci
>> Thin web server (v1.5.1 codename Straight Razor)
>> Maximum connections set to 1024
>> Listening on 0.0.0.0:54954, CTRL+C to stop
Waiting for jasmine server on 54954...
jasmine server started.
Phantomjs does not appear to be installed in /Users/dentarg/.phantomjs/1.9.2/darwin/bin/phantomjs, installing!
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0^C>> Stopping ...
--2013-12-05 17:18:55--  http://phantomjs.googlecode.com/files/phantomjs-1.9.2-macosx.zip
Resolving phantomjs.googlecode.com... 2a00:1450:4010:c03::52, 74.125.143.82
Connecting to phantomjs.googlecode.com|2a00:1450:4010:c03::52|:80... ^C>> Stopping ...

Maybe at least ask the user if she wants help with installing phantomjs? :)

I like to manage stuff like this by myself (with Homebrew).

(I'm trying out 2.0.0.rc5.)

ragaskar commented 10 years ago

This is a phantomjs-gem issue (https://github.com/colszowka/phantomjs-gem).If you have a phantomjs somewhere on your path, it shouldn't install (so if you like, can install via homebrew, nuke .phantom-js and re-run).

The phantom-js gem seems to make sense for jasmine-gem as jasmine will often be used in environments where managing your dependencies by yourself can often be complicated (a travis build, for example).

ragaskar commented 10 years ago

I should add, happy to take a doc pull that will describe this to users so they can avoid the auto-install if they like.

Thanks!

dentarg commented 10 years ago

Sure, I can send a PR.