search

jasmine / jasmine-gem

Jasmine ruby gem
682 stars 274 forks source link

jasmine gem 2.0.2 has massive performance loss in phantomjs runner #225

Closed rdy closed 10 years ago

rdy commented 10 years ago

Me and @ohrite tried to upgrade to the jasmine 2.0.2 gem to get the rails 4.1 support. We noticed that the jasmine:ci task seems to be extremely slow running under phantom. We didn't see this behavior with the older gem. It seems to be leaking memory and getting slower and slower over time.

This doesn't seem to happen with the regular web runner, so there must have been a regression introduced specifically with phantomjs. It seems to be a problem even from 2.0.1.

We haven't done any investigation to note the cause but we went from a 6-10 second test suite time to 4+ minutes (it never finished before we got impatient with it). Its most interesting that it works fine in chrome.

rdy commented 10 years ago

looks like its a regression somewhere in jasmine-core between 2.0.0 and 2.0.1 we'll file an issue over there.

we can close the issue once we isolate the offending commit in core.

slackersoft commented 10 years ago

If I had to guess, this is probably from the streaming reporter stuff. Not sure on the memory problem, but in order to get the streaming results, we're having phantomjs console.log each result and processing it it ruby as they come. I'd love to see a better way to do this, but I'm not sure what it is

slackersoft commented 10 years ago

Given this looks like an issue in core, can we close this gem issue? Or is there a gem-specific slowdown as well?

rdy commented 10 years ago

I'm cool with closing this issue here as it is an issue in core, people can work around this issue by explicitly requiring an older version of core in their Gemfile.